Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adds audio creation #761

Closed
wants to merge 5 commits into from
Closed

Conversation

cimigree
Copy link
Contributor

@cimigree cimigree commented Sep 26, 2024

Description

Adds the ability to create an audio file from an observation
Continues to address issue #360
Used this PR that Andrew created
Here are the designs

In order to make it more simple for review, this PR only adds the ability to create an audio recording. Almost all of this code comes directly from Andrew.
I tried to remove anything that was unnecessary (playing back the created audio, saving it, etc.) however, you should know that the way things are setup is meant to facilitate playing back and saving the audio and I can just add some code to this pre-existing setup for that functionality...

Instructions

  1. Make sure to add this to your env file: EXPO_PUBLIC_FEATURE_AUDIO=true
  2. Go to create an observation
  3. Hit the microphone
  4. Grant permission to record audio
  5. You will be taken to the create audio recording screen
  6. Watch the screen change color and the time pass and the countdown change.
  7. It will stop automatically at 5 minutes
  8. Hit the stop button to stop recording.
  9. Hit the Android back button to leave the screen.
  10. You can hit the microphone to try again
  11. Note there is no saving or playback yet. This PR is just about the create recording interface and functionality.

Copy link

sentry-io bot commented Sep 26, 2024

🔍 Existing Issues For Review

Your pull request is modifying functions with the following pre-existing issues:

📄 File: src/frontend/sharedComponents/ActionRow.tsx

Function Unhandled Issue
ActionsRow ReferenceError: Property 'openSheet' doesn't exist ActionsRow(/Users/cindygreen/awana/comapeo-mobile/src/frontend/sharedComponents/ActionRow.ts...
Event Count: 3 Affected Users: 1
ActionsRow ReferenceError: Property 'Audio' doesn't exist Ac...
Event Count: 1 Affected Users: 1
ActionsRow ReferenceError: Property 'isAudioPermissionSheetOpen' doesn't exist ActionsRow(/Users/cindygreen/awana/comapeo-mobile/src/frontend/sharedCompon...
Event Count: 1 Affected Users: 1
ActionsRow ReferenceError: Property 'handlePermissionGranted' doesn't exist ActionsRow(/Users/cindygreen/awana/comapeo-mobile/src/frontend/sharedComponent...
Event Count: 1 Affected Users: 1

Did you find this useful? React with a 👍 or 👎

@cimigree cimigree closed this Oct 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant